Skip to content

feat: improve default configuration for reliability and performance #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 19, 2025

Description

Fixes #685

Ran the smoke test and confirmed that the props are in hdfs-site.xml.

CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/25/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Jun 19, 2025
@razvan razvan changed the title issues/685 feat: improve default configuration for reliability and performance Jun 19, 2025
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jun 19, 2025
@razvan razvan requested a review from a team June 19, 2025 14:30
@lfrancke
Copy link
Member

I found a problem in my original issue. I believe at least one of the properties actually needs to go into core-site.xml instead. I'll check.

Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io.file.buffer.size needs to go into core-site.xml instead

Sorry for the mistake on my end :(

@razvan
Copy link
Member Author

razvan commented Jun 19, 2025

io.file.buffer.size needs to go into core-site.xml instead

Sorry I was too lazy to check. Moved.

@razvan razvan requested a review from lfrancke June 19, 2025 15:37
@razvan razvan enabled auto-merge June 19, 2025 15:44
@razvan razvan added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit 9339476 Jun 19, 2025
17 checks passed
@razvan razvan deleted the issues/685 branch June 19, 2025 15:58
@razvan razvan moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

Improve default configuration (reliability & performance)
2 participants